> > > + if (!(modes = virStringSplit(mode, ",", 0))) {
> >
> > Any reason you can't use vshStringToArray to do the split?
>
> I didn't know it existed - utility functions like that shouldn't
> be in virsh code anyway. Now I know it exists, I'll kill it off
> in favour of virStringSplit everywhere.
Except that vshStingToArray _also_ does ',,' unescaping, so that:
a,b,,c,d
is split into "a", "b,c", "d", rather than "a", "b", "", "c", "d"
so we'd still need a post-processing path after virStringSplit.
--
Eric Blake eblake@xxxxxxxxxx +1-919-301-3266
Libvirt virtualization library http://libvirt.org
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list