> > Alas, you are missing documentation of the new flags in > > src/libvirt.c (not that the existing flags were documented > > there yet), > > Well the docs refer to the corresponding enum, whcih will > be included in the docs with its descriptions. So isn't > that better than duplicating the enum descriptions again. I suppose that's okay, if you think the enum itself has enough details about what each flag means. http://libvirt.org/html/libvirt-libvirt.html#virDomainShutdownFlagValues But there's still the question of semantics, on whether we have properly captured the fact that you can now specify more than one flag, and if so, it is hypervisor choice on which order to attempt the flags. At any rate, ACK to this patch, now that you've done a separate patch for moving the mutual exclusion of flags into the qemu driver. -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list