On Fri, Nov 30, 2012 at 09:12:44AM -0500, Eric Blake wrote: > > > The fact that only the guest agent, or ACPI flag can be used > > > when requesting reboot/shutdown is merely a limitation of the > > > QEMU driver impl at this time. Thus it should not be in > > > libvirt.c code > > > > > > Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx> > > > --- > > > src/libvirt.c | 16 ---------------- > > > src/qemu/qemu_driver.c | 16 ++++++++++++++++ > > > 2 files changed, 16 insertions(+), 16 deletions(-) > > > > ACK. > > Problem. Now our virsh command doesn't have full expression of > the possible API usage. You need to modify 'virsh shutdown --mode=...' > so that --mode can now take a comma-separated list of modes to > combine, rather than only being able to select a single mode, if > you want to be able to stress-test the full power of the API. Ok, will send another patch todo that too Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list