Hi.
At Tue, 27 Nov 2012 23:03:38 +0100,
Jiri Denemark wrote:
>
> On Tue, Nov 27, 2012 at 13:10:57 -0500, Eric Blake wrote:
> > > + protected java.util.List getFieldOrder() {
> > > + return java.util.Arrays.asList(new String[] {
> > > + "credtype", "ncredtype", "cb", "cbdata" });
> > > + }
> >
> > Isn't it sufficient to write:
> >
> > return java.util.Arrays.asList("credtype", "ncredtype", "cb", "cbdata")
> >
> > and let Java do the conversion from var-args to String[] with less typing
> > on your part?
>
> Hmm, I guess so. I didn't actually think about this part too much, I just
> copied the style used in jna itself :-)
>
> > But that's cosmetic. ACK whether you go as-is or use shorter syntax.
>
> Thanks, I pushed this patch as-is.
I already send a patch which does this back in October.
See
https://www.redhat.com/archives/libvir-list/2012-October/msg00593.html
which is part of the changeset here:
https://www.redhat.com/archives/libvir-list/2012-October/msg00578.html
--
AV-Test GmbH, Henricistraße 20, 04155 Leipzig, Germany
Phone: +49 341 265 310 19
Web:<http://www.av-test.org>
Eingetragen am / Registered at: Amtsgericht Stendal (HRB 114076)
Geschaeftsfuehrer (CEO): Andreas Marx, Guido Habicht, Maik Morgenstern
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list