On Thu, Nov 08, 2012 at 10:51:14AM -0500, Dave Allan wrote: > On Thu, Nov 08, 2012 at 03:24:07PM +0100, Daniel P. Berrange wrote: > > On Mon, Nov 05, 2012 at 12:59:16PM -0700, Eric Blake wrote: > > > https://bugzilla.redhat.com/show_bug.cgi?id=873344 suggested that > > > the grouping 'boot', 'shutdown', 'reboot'; as well as the grouping > > > 'start', 'stop', 'restart'; might be easier to remember than the > > > current mix of 'start', 'shutdown', 'reboot'. > > > > > > * tools/virsh-domain.c (domManagementCmds): Add other command names. > > > * tools/virsh.pod (start, shutdown, reboot): Document the aliases. > > > --- > > > > > > This patch documents both spellings. An alternative would be to > > > leave the alternate spellings as hidden aliases (virsh has support > > > for that), but still mention them in virsh.pod (see how we did an > > > alias for nodedev-dettach, for reference). > > > > NACK to this patch. I think the current command names are good. > > Creating duplicates will make life worse. First, it creates > > divergance from the similarly named commands for networks, > > storage and other objects. It also means scripts written again > > the new commands will not work with existing libvirt. > > > > I actually think that shutdown & reboot are *better* names > > than restart and stop. > > > > If we wanted to replace any existing names, then the 'create' > > and 'destroy' names are the ones to replace, and for those I > > would expect to use 'boot' and 'stop'. I still don't thin > > we should do that either, due to creating inconsistency with > > other commands. > > IMO this is fundamentally an aesthetic question here that's not going > to be solved by debate, however, from the comments so far, the patch > seems to have a fair amount of support. DV, perhaps you could weigh > in with your opinion? Since this is an aesthetic question, even adding this patch is not going to solve it. It is a fact of life that there are a huge variety of names that could be used - adding more & more aliases is not a solution. You can never satisfy everyone's desired name choice. You just have to pick one name and stick with it consistently. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list