Re: [PATCH] qemu: Don't corrupt pointer in qemuDomainSaveMemory()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/06/2012 03:07 AM, Peter Krempa wrote:
> The code that was split out into the qemuDomainSaveMemory expands the
> pointer containing the XML description of the domain that it gets from
> higher layers. If the pointer changes the old one is invalid and the
> upper layer function tries to free it causing an abort.
> 
> This patch changes the expansion of the original string to a new
> alocation and copy of the contents.

s/alocation/allocation/

> ---
>  src/qemu/qemu_driver.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)

ACK.  Good find, and hidden enough that I can see how I missed it in the
first review.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]