Looks good, ACK
Christophe
On Wed, Oct 31, 2012 at 11:51:54PM +0200, Zeeshan Ali (Khattak) wrote:
> From: "Zeeshan Ali (Khattak)" <zeeshanak@xxxxxxxxx>
>
> Add flags to be used with gvir_domain_reboot().
> ---
> libvirt-gobject/libvirt-gobject-domain.c | 2 +-
> libvirt-gobject/libvirt-gobject-domain.h | 13 +++++++++++++
> libvirt-gobject/libvirt-gobject.sym | 5 +++++
> 3 files changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/libvirt-gobject/libvirt-gobject-domain.c b/libvirt-gobject/libvirt-gobject-domain.c
> index 8ade3ea..c1ba5ce 100644
> --- a/libvirt-gobject/libvirt-gobject-domain.c
> +++ b/libvirt-gobject/libvirt-gobject-domain.c
> @@ -688,7 +688,7 @@ gboolean gvir_domain_shutdown(GVirDomain *dom,
> /**
> * gvir_domain_reboot:
> * @dom: the domain
> - * @flags: the flags
> + * @flags: the %GVirDomainRebootFlags flags
> */
> gboolean gvir_domain_reboot(GVirDomain *dom,
> guint flags,
> diff --git a/libvirt-gobject/libvirt-gobject-domain.h b/libvirt-gobject/libvirt-gobject-domain.h
> index 6e7b10d..bd0cfc0 100644
> --- a/libvirt-gobject/libvirt-gobject-domain.h
> +++ b/libvirt-gobject/libvirt-gobject-domain.h
> @@ -158,6 +158,19 @@ typedef enum {
> GVIR_DOMAIN_SNAPSHOT_ATOMIC = VIR_DOMAIN_SNAPSHOT_CREATE_ATOMIC,
> } GVirDomainSnapshotCreateFlags;
>
> +/**
> + * GVirDomainRebootFlags:
> + * @GVIR_DOMAIN_REBOOT_NONE: No flags, hypervisor choice
> + * @GVIR_DOMAIN_REBOOT_ACPI_POWER_BTN: Send ACPI event
> + * @GVIR_DOMAIN_REBOOT_GUEST_AGENT: Use guest agent
> + *
> + */
> +typedef enum {
> + GVIR_DOMAIN_REBOOT_NONE = 0,
> + GVIR_DOMAIN_REBOOT_ACPI_POWER_BTN = VIR_DOMAIN_REBOOT_ACPI_POWER_BTN,
> + GVIR_DOMAIN_REBOOT_GUEST_AGENT = VIR_DOMAIN_REBOOT_GUEST_AGENT,
> +} GVirDomainRebootFlags;
> +
> typedef struct _GVirDomainInfo GVirDomainInfo;
> struct _GVirDomainInfo
> {
> diff --git a/libvirt-gobject/libvirt-gobject.sym b/libvirt-gobject/libvirt-gobject.sym
> index 3a40a8a..444a891 100644
> --- a/libvirt-gobject/libvirt-gobject.sym
> +++ b/libvirt-gobject/libvirt-gobject.sym
> @@ -204,4 +204,9 @@ LIBVIRT_GOBJECT_0.1.3 {
> gvir_domain_wakeup_finish;
> } LIBVIRT_GOBJECT_0.1.2;
>
> +LIBVIRT_GOBJECT_0.1.4 {
> + global:
> + gvir_domain_reboot_flags_get_type;
> +} LIBVIRT_GOBJECT_0.1.3;
> +
> # .... define new API here using predicted next version number ....
> --
> 1.7.12.1
>
> --
> libvir-list mailing list
> libvir-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/libvir-list
Attachment:
pgpOON62aqnMQ.pgp
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list