On Mon, Nov 05, 2012 at 12:59:16PM -0700, Eric Blake wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=873344 suggested that > the grouping 'boot', 'shutdown', 'reboot'; as well as the grouping > 'start', 'stop', 'restart'; might be easier to remember than the > current mix of 'start', 'shutdown', 'reboot'. > > * tools/virsh-domain.c (domManagementCmds): Add other command names. > * tools/virsh.pod (start, shutdown, reboot): Document the aliases. > --- > > This patch documents both spellings. An alternative would be to > leave the alternate spellings as hidden aliases (virsh has support > for that), but still mention them in virsh.pod (see how we did an > alias for nodedev-dettach, for reference). I don't see any reason to hide them; as long as we're being backward compatible, I think we're doing the right thing, and we should let people know that these options exist. Dave > tools/virsh-domain.c | 3 +++ > tools/virsh.pod | 4 ++++ > 2 files changed, 7 insertions(+) > > diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c > index 393b67b..86ed4d3 100644 > --- a/tools/virsh-domain.c > +++ b/tools/virsh-domain.c > @@ -8298,6 +8298,7 @@ const vshCmdDef domManagementCmds[] = { > {"blockjob", cmdBlockJob, opts_block_job, info_block_job, 0}, > {"blockpull", cmdBlockPull, opts_block_pull, info_block_pull, 0}, > {"blockresize", cmdBlockResize, opts_block_resize, info_block_resize, 0}, > + {"boot", cmdStart, opts_start, info_start, 0}, > {"change-media", cmdChangeMedia, opts_change_media, info_change_media, 0}, > #ifndef WIN32 > {"console", cmdConsole, opts_console, info_console, 0}, > @@ -8351,6 +8352,7 @@ const vshCmdDef domManagementCmds[] = { > {"numatune", cmdNumatune, opts_numatune, info_numatune, 0}, > {"reboot", cmdReboot, opts_reboot, info_reboot, 0}, > {"reset", cmdReset, opts_reset, info_reset, 0}, > + {"restart", cmdReboot, opts_reboot, info_reboot, 0}, > {"restore", cmdRestore, opts_restore, info_restore, 0}, > {"resume", cmdResume, opts_resume, info_resume, 0}, > {"save", cmdSave, opts_save, info_save, 0}, > @@ -8367,6 +8369,7 @@ const vshCmdDef domManagementCmds[] = { > {"setvcpus", cmdSetvcpus, opts_setvcpus, info_setvcpus, 0}, > {"shutdown", cmdShutdown, opts_shutdown, info_shutdown, 0}, > {"start", cmdStart, opts_start, info_start, 0}, > + {"stop", cmdShutdown, opts_shutdown, info_shutdown, 0}, > {"suspend", cmdSuspend, opts_suspend, info_suspend, 0}, > {"ttyconsole", cmdTTYConsole, opts_ttyconsole, info_ttyconsole, 0}, > {"undefine", cmdUndefine, opts_undefine, info_undefine, 0}, > diff --git a/tools/virsh.pod b/tools/virsh.pod > index e0c6b42..7a3835b 100644 > --- a/tools/virsh.pod > +++ b/tools/virsh.pod > @@ -1124,6 +1124,7 @@ If I<--config> is specified, affect the next boot of a persistent guest. > If I<--current> is specified, affect the current guest state. > > =item B<reboot> I<domain> [I<--mode acpi|agent>] > +=item B<restart> I<domain> [I<--mode acpi|agent>] > > Reboot a domain. This acts just as if the domain had the B<reboot> > command run from the console. The command returns as soon as it has > @@ -1523,6 +1524,7 @@ be hot-plugged the next time the domain is booted. As such, it must only be > used with the I<--config> flag, and not with the I<--live> flag. > > =item B<shutdown> I<domain> [I<--mode acpi|agent>] > +=item B<stop> I<domain> [I<--mode acpi|agent>] > > Gracefully shuts down a domain. This coordinates with the domain OS > to perform graceful shutdown, so there is no guarantee that it will > @@ -1543,6 +1545,8 @@ can specify C<acpi> or C<agent>. > > =item B<start> I<domain-name-or-uuid> [I<--console>] [I<--paused>] > [I<--autodestroy>] [I<--bypass-cache>] [I<--force-boot>] > +=item B<boot> I<domain-name-or-uuid> [I<--console>] [I<--paused>] > +[I<--autodestroy>] [I<--bypass-cache>] [I<--force-boot>] > > Start a (previously defined) inactive domain, either from the last > B<managedsave> state, or via a fresh boot if no managedsave state is > -- > 1.7.11.7 > > -- > libvir-list mailing list > libvir-list@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/libvir-list -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list