Re: [PATCH] Don't assume pid_t is the same size as an int

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/31/2012 11:02 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
> 
> virPidFileReadPathIfAlive passed in an 'int *' where a 'pid_t *'
> was expected, which breaks on Mingw64 targets. Also a few places
> were using '%d' for formatting pid_t, change them to '%lld' and
> force a cast to the longer type as done elsewhere in the same
> file.
> 
> Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
> ---
>  src/util/virpidfile.c |  4 ++--
>  src/util/virprocess.c | 13 +++++++------
>  2 files changed, 9 insertions(+), 8 deletions(-)

ACK.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]