On Fri, Oct 26, 2012 at 11:59 AM, Philipp Hahn <hahn@xxxxxxxxxxxxx> wrote:
> Hello,
>
> just a nit:
>
> On Tuesday 23 October 2012 10:09:11 li guang wrote:
>> > +++ b/src/qemu/qemu_driver.c
>> > @@ -9622,6 +9622,20 @@ qemuDomainMigrateBegin3(virDomainPtr domain,
>> > }
>> >
>> > if (!virDomainObjIsActive(vm)) {
>> > + if (flags & VIR_MIGRATE_OFFLINE) {
>> > + if (flags & (VIR_MIGRATE_NON_SHARED_DISK|
>> > + VIR_MIGRATE_NON_SHARED_INC)) {
>> > + virReportError(VIR_ERR_OPERATION_INVALID,
>> > + "%s", _("migrating storage handled by
>> > volume APIs")); + goto endjob;
>> > + }
>> > + if (!(flags & VIR_MIGRATE_PERSIST_DEST)) {
>> > + virReportError(VIR_ERR_OPERATION_INVALID,
>> > + "%s", _("VIR_MIGRATE_OFFLINE should
>> > combined with VIR_MIGRATE_PERSIST_DEST"));
> ^ be" ?
> or even "should" -> "must be"?
>
> Sincerely
> Philipp
> --
One of the things that I addressed with my code review patch to be
squashed into this patch.
--
Doug Goldstein
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list