On Thu, Oct 25, 2012 at 09:43:28 -0400, Dave Allan wrote: > On Thu, Oct 25, 2012 at 07:16:35AM -0600, Eric Blake wrote: > > I disagree - there's no point in keeping a hidden argument. It is a > > disservice to users to make them have to pass a numeric flags value - if > > they know they are talking to a new enough server that supports a new > > flag, then they should be able to upgrade to a new enough virsh that > > exposes that new flag as a human-readable option name, or directly code > > their task using C or python bindings instead of bothering with virsh. > > > > I think the patch is fine as-is. > > +1 Looks like the consensus is that it is safe to remove --flags. I pushed this patch. Jirka -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list