On Wed, Oct 24, 2012 at 08:30:02AM -0600, Eric Blake wrote: > On 10/24/2012 03:20 AM, Daniel P. Berrange wrote: > > On Tue, Oct 23, 2012 at 12:01:02PM -0600, Eric Blake wrote: > >> Commit 12ad7435 added new functions (virNodeGetMemoryParameters, > >> virNodeSetMemoryParameters) into the section of the file reserved > >> for deprecated names. Fix this by moving things earlier; split > >> into two patches to make git diff easier to read. > >> > >> * include/libvirt/libvirt.h.in: Move virTypedParameter earlier. > >> --- > >> include/libvirt/libvirt.h.in | 174 ++++++++++++++++++++++--------------------- > >> 1 file changed, 88 insertions(+), 86 deletions(-) > > > > I have to say I would dearly love to split up our header file into > > a number of pieces, since it is really a huge mess as it is. I'd > > like to have > > > > libvirt/virerror.h > > libvirt/virmisc.h > > libvirt/virconnect.h > > libvirt/virdomain.h > > libvirt/virnetwork.h > > libvirt/virnodedev.h > > libvirt/virinterface.h > > libvirt/..etc... > > Agreed, and this is not the first time this has come up. However, the > last time I attempted this, I ran into walls trying to figure out how to > make the documentation generation work across multiple headers, and it > wasn't high enough on my priorities to resolve at that time. Also, it > sounds invasive enough to save until after 1.0.0 is released. Oh right, forgot about the docs generator pain. Of course it can wait till after 1.0.0 Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list