Re: [PATCH v3 2/4] monitor: Enable adding an inherited fd to an fd set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/16/2012 12:08 PM, Corey Bryant wrote:
> qmp_add_fd() gets an fd that was received over a socket with
> SCM_RIGHTS and adds it to an fd set.  This patch adds support
> that will enable adding an fd that was inherited on the
> command line to an fd set.
> 
> Note: All of the code added to monitor_fdset_add_fd(), with the
> exception of the error path for non-valid fdset-id, is code motion
> from qmp_add_fd().
> 
> Signed-off-by: Corey Bryant <coreyb@xxxxxxxxxxxxxxxxxx>
> ---
> v2:
>   -Removed Error** parameter from monitor_fdset_add_fd()
> 
> v3:
>   -Added Error** parameter back to monitor_fdset_add_fd()
>   -Move 'if (!mon_fdset_cur)' change to patch 1 (kwolf@xxxxxxxxxx)
>   -Move code that prevents removal of fd from fd set during init
>    to it's own patch (eblake@xxxxxxxxxx, kwolf@xxxxxxxxxx)
>   -Mention code motion in commit message (kwolf@xxxxxxxxxx)

Reviewed-by: Eric Blake <eblake@xxxxxxxxxx>

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]