The comment stated that you may call qemuDomainObjBeginJobWithDriver() without passing qemud_driver to signalize it's not locked. qemuDomainObjBeginJobWithDriver still accesses the qemud_driver structure and the lock singalling is done through a separate parameter. --- src/qemu/qemu_domain.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 17ae3b9..19ba099 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -884,8 +884,7 @@ int qemuDomainObjBeginAsyncJob(struct qemud_driver *driver, } /* - * obj must be locked before calling. If qemud_driver is passed, it MUST be - * locked; otherwise it MUST NOT be locked. + * obj and qemud_driver must be locked before calling. * * This must be called by anything that will change the VM state * in any way, or anything that will use the QEMU monitor. -- 1.7.12 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list