On 10/08/2012 01:16 PM, Marcelo Cerri wrote: >>> +int virGetUserID(const char *user, uid_t *uid) >>> +{ >>> + unsigned int uint_uid; >> >> Are we sure that 'unsigned int' is large enough for uid_t on all >> platforms? I'd feel safer with something like: >> >> verify(sizeof(unsigned int) >= sizeof(uid_t)); >> >> added to enforce this with the compiler. > > Hi Eric, just a note: this seems to be already added by you :) > > http://libvirt.org/git/?p=libvirt.git;a=commit;h=7f31e28c6efa3aba17f1e6ee333135949379be7d Good, this aspect is taken care of then :) -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list