On Fri, Oct 05, 2012 at 12:40:39PM +0100, Richard W.M. Jones wrote: > > I notice that the qemu driver doesn't support snapshot drives > (-drive file=foo,snapshot=on). This is important for libguestfs. > > Currently libguestfs hacks this using <qemu:arg>. That works fine for > static disks in the libvirt XML, but lack of direct support in libvirt > is a blocker for adding hotplugging to libguestfs. > > In qemu, the snapshot=on feature does several things: > > (a) It creates a temporary qcow2 disk in $TMPDIR. We really need to ask QEMU guys to add a config parameter to specify the location of the snapshot disks. It is nuts to rely on TMPDIR for this purpose. No problem implementing the rest of the libvirt support in the meantime though. We'll just add another XML attribute to configure the snapshot location once QEMU is suitably functional Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list