On 05.10.2012 14:23, Eric Blake wrote: > On 10/05/2012 05:36 AM, Michal Privoznik wrote: >> After it got renamed to virProcessKill (cf470068a11) >> it is no longer needed in the private syms file. >> --- >> >> It is trivial, but maybe worth inventing cfg.mk macro >> that does check if all symbols fro private syms are >> defined somewhere. However, I am not that familiar >> with cfg.mk, so if anybody has any idea ... > > src/check-symfile.pl ought to be able to flag this case as part of 'make > check'; I'm not sure why it is failing to do what it claims. Ah, I see now. It checks the public syms only. Follow up patch coming. > >> +++ b/src/libvirt_private.syms >> @@ -1246,7 +1246,6 @@ virGetUserName; >> virHexToBin; >> virIndexToDiskName; >> virIsDevMapperDevice; >> -virKillProcess; > > ACK. > > Thanks pushed. Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list