On Mon, Oct 01, 2012 at 05:38:56PM -0600, Eric Blake wrote: > Commit f6430390 broke builds on RHEL 5, where glibc (2.5) is too > old to support mkostemp (2.7) or htole64 (2.9). While gnulib > has mkostemp, it still lacks htole64; and it's not worth dragging > in replacements on systems where journald is unlikely to exist > in the first place, so we just use an extra configure-time check > as our witness of whether to attempt compiling the code. > > * src/util/logging.c (virLogParseOutputs): Don't attempt to > compile journald on older glibc. > * configure.ac (AC_CHECK_DECLS): Check for htole64. > --- > > v2: use correct configure probe. > Now tested on both F17 and RHEL 5, so finally pushing under the > build-breaker rule. ACK Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list