Re: [PATCH] Fix deadlock in handling EOF in LXC monitor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/26/2012 08:34 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
> 
> Depending on the scenario in which LXC containers exit, it is
> possible for the EOF callback of the LXC monitor to deadlock
> the driver. When the driver calls virLXCMonitorClose, there
> is really no need for the EOF callback to be invoked in this
> case, since the caller can easily handle events itself.
> 
> In changing this, the monitor needs to take a deep copy of
> the callback list, not merely a reference.
> 
> Also adds debug statements in various places to aid
> troubleshooting
> 
> Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
> ---
>  src/lxc/lxc_monitor.c | 32 ++++++++++++++++++++++----------
>  src/lxc/lxc_process.c |  6 +++++-
>  2 files changed, 27 insertions(+), 11 deletions(-)
> 

ACK.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]