On 21.09.2012 23:06, Laine Stump wrote: > On 09/21/2012 04:47 PM, Shawn Furrow wrote: >> Hi all, >> >> I feel really bad sending this through the libvirt-list but the email >> provided at the bottom of the patch page is rejecting my email. >> >> I have a patch for Libvirt but I am unsure how to go about doing it. I >> saw that on the patches page it says to submit the patch using >> Mercurial's patchbomb extension. > > Where did you see this? libvirt has used git for a very long time, and > I've never previously heard of any suggestion to use a mercurial tool to > send a patch to libvir-list. Either the page is *way* out of date, or > referring to something else. > > Up-to-date instructions for sending patches are in the HACKING file in > the toplevel directory of the libvirt tree. Basically, use "git > send-email" if at all possible. HACKING is available online too: http://libvirt.org/hacking.html Don't forget to check your patch with 'make check && make syntax-check'. Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list