Re: [PATCH 2/3] build: fix nodeinfo build on non-Linux platforms

[Osier Yang <jyang@xxxxxxxxxx>]

On 2012年09月19日 09:57, Eric Blake wrote:
> Commit aaa8ab3 added new static functions that are only used on Linux;
> but commit 22acfdc didn't go far enough to fix compiler issues.
>
> * src/nodeinfo.c (nodeSetMemoryParameterValue)
> (nodeGetMemoryParameterValue): Conditionally compile based on use.
> ---
>   src/nodeinfo.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/src/nodeinfo.c b/src/nodeinfo.c
> index 302e017..b2de60f 100644
> --- a/src/nodeinfo.c
> +++ b/src/nodeinfo.c
> @@ -931,6 +931,7 @@ nodeGetCPUmap(virConnectPtr conn ATTRIBUTE_UNUSED,
>   #endif
>   }
>
> +#ifdef __linux__
>   static int
>   nodeSetMemoryParameterValue(const char *field,
>                               virTypedParameterPtr param)
> @@ -964,6 +965,7 @@ cleanup:
>       VIR_FREE(strval);
>       return ret;
>   }
> +#endif
>
>   int
>   nodeSetMemoryParameters(virConnectPtr conn ATTRIBUTE_UNUSED,
> @@ -1014,6 +1016,7 @@ nodeSetMemoryParameters(virConnectPtr conn ATTRIBUTE_UNUSED,
>   #endif
>   }
>
> +#ifdef __linux__
>   static int
>   nodeGetMemoryParameterValue(const char *field,
>                               void *value)
> @@ -1058,6 +1061,7 @@ cleanup:
>       VIR_FREE(buf);
>       return ret;
>   }
> +#endif
>
>   #define NODE_MEMORY_PARAMETERS_NUM 7
>   int

ACK, Thanks for fixing bug by me. :-)

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list