Re: [PATCH 0/4 v3] Support to set disk wwn

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2012年09月18日 10:47, Osier Yang wrote:

v2 - v3:
   * Just rebase on the top.

v1 - v2:
   * Validate wwn while parsing
   * Error out earlier "if (disk->device == "lun"&&  disk->wwn)", no
     logic change.

This introduces new element<wwn>  for disk, to allow to set wwn
(just like setting serial number) for the virtual disk (Only QEMU
devices like ide-drive, ide-hd, ide-cd, scsi-disk, scsi-hd, and
scsi-cd support it).


Osier Yang (4):
   schema: Add schema for disk<wwn>
   conf: Parse and format disk<wwn>
   qemu: Add caps to indentify if setting wwn is supported by qemu
   qemu: Use disk wwn in qemu command line

  docs/formatdomain.html.in                          |    6 +++
  docs/schemas/basictypes.rng                        |    6 +++
  docs/schemas/domaincommon.rng                      |    5 +++
  docs/schemas/nodedev.rng                           |    6 ---
  src/conf/domain_conf.c                             |   12 +++++++
  src/conf/domain_conf.h                             |    1 +
  src/libvirt_private.syms                           |    1 +
  src/qemu/qemu_capabilities.c                       |    8 ++++
  src/qemu/qemu_capabilities.h                       |    2 +
  src/qemu/qemu_command.c                            |   33 ++++++++++++++++++
  src/util/util.c                                    |   17 +++++++++
  src/util/util.h                                    |    2 +
  .../qemuxml2argv-disk-ide-wwn.args                 |    6 +++
  .../qemuxml2argvdata/qemuxml2argv-disk-ide-wwn.xml |   28 ++++++++++++++++
  .../qemuxml2argv-disk-scsi-disk-wwn.args           |   10 ++++++
  .../qemuxml2argv-disk-scsi-disk-wwn.xml            |   35 ++++++++++++++++++++
  tests/qemuxml2argvtest.c                           |    7 ++++
  17 files changed, 179 insertions(+), 6 deletions(-)
  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-ide-wwn.args
  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-ide-wwn.xml
  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-scsi-disk-wwn.args
  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-scsi-disk-wwn.xml


Pushed the test, thanks.

Regards,
Osier

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]