Re: [PATCH] Don't overwrite errors raised by qemuMonitorHMPCommand

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 13, 2012 at 02:29:50PM +0100, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
> 
> The qemuMonitorHMPCommand() API and things it calls will report
> a wide variety of errors. The QEMU text monitor should not be
> overwriting these errors
> 
> Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>

  ACK,

painful to review, I wish we had semantic patching like coccinelle
ideally we should be able to stack error reports:
  - failed to migrate foo
  - failed to resume foo on target
  - out of memory
i.e. the errors at different layers may all be meaningful in different
ways.

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel@xxxxxxxxxxxx  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]