On 09/11/2012 08:11 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" <berrange@xxxxxxxxxx> > > The current qemu capabilities are stored in a virBitmapPtr > object, whose type is exposed to callers. We want to store > more data besides just the flags, so we need to move to a > struct type. This object will also need to be reference > counted, since we'll be maintaining a cache of data per > binary. This change introduces a 'qemuCapsPtr' virObject > class. Most of the change is just renaming types and > variables in all the callers > > Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx> > --- > src/qemu/qemu_capabilities.c | 376 ++++++++++++++++------------ > src/qemu/qemu_capabilities.h | 29 ++- > src/qemu/qemu_command.c | 580 +++++++++++++++++++++---------------------- > src/qemu/qemu_command.h | 53 ++-- > src/qemu/qemu_domain.c | 16 +- > src/qemu/qemu_domain.h | 4 +- > src/qemu/qemu_driver.c | 40 +-- > src/qemu/qemu_hotplug.c | 138 +++++----- > src/qemu/qemu_migration.c | 16 +- > src/qemu/qemu_monitor.c | 6 +- > src/qemu/qemu_monitor.h | 3 +- > src/qemu/qemu_monitor_json.c | 16 +- > src/qemu/qemu_monitor_json.h | 4 +- > src/qemu/qemu_process.c | 62 ++--- > tests/qemuhelptest.c | 16 +- > tests/qemuxml2argvtest.c | 6 +- > tests/qemuxmlnstest.c | 6 +- > 17 files changed, 712 insertions(+), 659 deletions(-) Slightly more additions than removals; I'm hoping it's due to the new struct, and maybe a few places where the renaming let you split long lines. > @@ -1644,54 +1666,80 @@ int qemuCapsExtractVersion(virCapsPtr caps, > } > > > -virBitmapPtr > + > + > +qemuCapsPtr A lot of blank lines here. ACK. -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list