Re: [PATCH V6] support offline migration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



在 2012-09-11二的 08:30 -0600,Eric Blake写道:

> 
> You either need to take care of migrating storage if the user does
> 'virsh migrate [whatever-we-decide-for-offline] --copy-storage-*', or
> else explicitly reject attempts to migrate storage in parallel with an
> offline migration.

right, I'll reject --copy-storage-* and error out.

> 
> > @@ -439,6 +441,11 @@ qemuMigrationCookieXMLFormat(struct qemud_driver *driver,
> >          virBufferAdjustIndent(buf, -2);
> >      }
> >  
> > +    if (mig->flags & QEMU_MIGRATION_COOKIE_OFFLINE) {
> > +        virBufferAsprintf(buf, "  <offline>\n");
> > +        virBufferAddLit(buf, "  </offline>\n");
> 
> Collapse these two lines into the simpler one-liner:
> 
> virBufferAddLit(buf, "  <offline/>\n");
> 

OK, I'll collapse them into one.

Thanks!

-- 
liguang    lig.fnst@xxxxxxxxxxxxxx
FNST linux kernel team


--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]