Re: [PATCH 6/7] virsh: Fix a bug of nodedev-list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/06/2012 03:43 PM, Peter Krempa wrote:
> On 09/05/12 07:34, Osier Yang wrote:
>> output of commands like '%virsh nodedev-list --tree --cap pci'
>> could be empty.

The moment you introduce filtering, --tree output no longer makes sense
(if a child has --cap pci but the parent does not, then you've lost tree
output).  I'd much rather have a patch that rejects the virsh command up
front if --tree is mixed with --cap, as the command no longer makes sense.

> 
> NACK to this patch as it breaks the output.

I agree with the NACK and that a different approach is needed.

-- 
Eric Blake   eblake@xxxxxxxxxx    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]