On 09/05/2012 12:52 AM, Martin Kletzander wrote: > On 09/05/2012 01:36 AM, Eric Blake wrote: >> Today's patches pointed out that virsh was still using localtime(), >> which is not thread-safe, even though virsh is definitely >> multi-threaded. >> >> * cfg.mk (exclude_file_name_regexp--sc_prohibit_nonreentrant): >> Tighten the rule. >> * tools/virsh.c (vshOutputLogFile): Avoid localtime. >> (vshEditWriteToTempFile, vshEditReadBackFile, cmdCd, cmdPwd) >> (vshCloseLogFile): Avoid strerror. >> * tools/console.c (vshMakeStdinRaw): Likewise. >> * tools/virsh-domain.c (vshGenFileName): Fix spacing in previous >> patch. >> --- >> cfg.mk | 2 +- >> tools/console.c | 11 +++++++---- >> tools/virsh-domain.c | 2 +- >> tools/virsh.c | 40 ++++++++++++++++++++++++---------------- >> 4 files changed, 33 insertions(+), 22 deletions(-) >> > > ACK, > Thanks; pushed, after tweaking the commit message to call out a commit id (as it is no longer "today's patches", but yesterday). -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list