在 2012-09-05三的 08:51 +0800，liguang写道： > 在 2012-09-04二的 12:12 +0100，Daniel P. Berrange写道： > > On Mon, Sep 03, 2012 at 02:23:24PM +0800, liguang wrote: > > > allow migration even domain isn't active by > > > inserting some stubs to tunnel migration path. > > > > > > Signed-off-by: liguang <lig.fnst@xxxxxxxxxxxxxx> > > > --- > > > src/qemu/qemu_driver.c | 2 +- > > > src/qemu/qemu_migration.c | 181 > > > +++++++++++++++++++++++++++++++++++++++++++-- > > > src/qemu/qemu_migration.h | 3 +- > > > 3 files changed, 178 insertions(+), 8 deletions(-) > > > > I really don't like the general design of this patch, even Yes, really not a general design, by now only domainMigratePrepareTunnel3 support transfer data by stream as I see, so I choose this path to migrate disk images. > > ignoring all the code bugs. I think this entire patch is > > really just a solution in search of a problem. Offline migration > > is already possible with existing libvirt APIs: > > > > domsrc = virDomainLookupByName(connsrc, "someguest"); > > xml = virDomainGetXMLDesc(domsrc); > > domdst virDomainDefine(conndst, xml); > > > > Um, maybe you mean offline migration is just redefinition of domain at > target side, but what about disk images the domain used without sharing > files between source and target, do we have to take a look at this case? > > > This proposed patch does not offer enough (or indeed any) compelling > > benefit over the above, to make it worth the including these hacks. > > > > NACK to the entire patch. > > > > Daniel. > -- liguang lig.fnst@xxxxxxxxxxxxxx FNST linux kernel team -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list