On Mon, Sep 03, 2012 at 06:29:47PM +0800, Osier Yang wrote: > On 2012年08月29日 14:44, Daniel P. Berrange wrote: > >On Wed, Aug 29, 2012 at 01:29:37AM -0400, Alex Jia wrote: > >>ACK. > >> > >>-- > >>Regards, > >>Alex > >> > >> > >>----- Original Message ----- > >>From: "Osier Yang"<jyang@xxxxxxxxxx> > >>To: libvir-list@xxxxxxxxxx > >>Sent: Tuesday, August 28, 2012 11:52:24 PM > >>Subject: [libvirt-perl PATCH] Fix several APIs > >> > >>These APIs accept one more argument (flags), which was ignored in > >>the XS implementations. > >>--- > >> Virt.xs | 46 ++++++++++++++++++++++++++-------------------- > >> 1 files changed, 26 insertions(+), 20 deletions(-) > > > >ACK, if you also update the Domain.pm docs to mention the new flags > >parameters > > > > Thanks, Pushed with the doc and nits pointed out by gren updated > (btw, most of the flags for APIs are not documented, and even some > constants, such as constants for virTypedParameterFlags, could be > later patch). Those constants should not be required, since the conversiuon is done internally. There is a test suite which validates that all libvirt public constants are present in the Perl binding, minus some blacklisted constants like virTypedParameterFlags ones Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list