Re: [PATCH 2/2] vcpupin: Fix returning of arrays from virDomainVcpuPinAdd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/30/12 16:09, Daniel Veillard wrote:
On Thu, Aug 30, 2012 at 03:51:55PM +0200, Peter Krempa wrote:
virDomainVcpuPinAdd does a realloc on vcpupin_list if the new vcpu pin
definition doesn't fit into the array. The list is an array of pointers
but the function definition didn't support returning the changed pointer
to the caller if it was realloced. This caused segfaults if realloc
would change the base pointer.
---
  src/conf/domain_conf.c   | 8 ++++----
  src/conf/domain_conf.h   | 2 +-
  src/libxl/libxl_driver.c | 2 +-
  src/qemu/qemu_driver.c   | 6 +++---
  src/xen/xend_internal.c  | 2 +-
  5 files changed, 10 insertions(+), 10 deletions(-)



   Nice catch ! ACK,

Daniel


Pushed. Thanks!

Peter



--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]