On Sat, Aug 25, 2012 at 02:57:28PM -0400, Laine Stump wrote: > On 08/24/2012 06:04 PM, Eric Blake wrote: > > On 08/24/2012 03:57 PM, Laine Stump wrote: > >> Everything is ready in both netcf and libvirt to switch over to libnl3 > >> in future releases of both Fedora and RHEL. This needs to be done more > >> or less simultaneously in both packages, though, because you can't mix > >> libnl1.1 and libnl3 in the same process (e.g. libvirtd using > >> libnl-3.so and libnetcf.so, while libnetcf.so uses libnl.so) > >> > >> This patch does two things when fedora >= 18 || rhel >= 7): > >> > >> 1) requires libnl3-devel > >> 2) requires netcf-devel-0.2.2 or greater > >> > >> (the idea is that a similar patch is going into netcf's specfile, so > >> that when a build of netcf is done on F18 or later (or RHEL7 or later) > >> netcf will be guaranteed to be built with libnl3 rather than > >> libnl-1.1) > >> --- > >> libvirt.spec.in | 9 +++++++++ > >> 1 file changed, 9 insertions(+) > > Makes sense - you have my ACK from a review standpoint, although I'd at > > least like to test a build against the netcf package from F18 > > updates-testing if we have time to do that before DV cuts the 0.10.0 > > release. > > Okay, I've cut the netcf-0.2.2 release, done builds for F18 and rawhide, > submitted the F18 update, and added a build-override to force use of > netcf-0.2.2.fc18. > > On the libvirt side, I tried a scratch build on f18 and found a problem > with CFLAGS that only occurs when building on a system that has > libnl3-devel only (no libnl-devel). I pushed a patch for that (because > it's a one line build breaker) and scratch builds with the updated > libvirt.spec now build properly with netcf-0.2.2 and libnl3-devel. > > So everything should be okay to push the original patch in this thread. > As we've discussed, it will be much simpler to deal with if we can do > that before 0.10.0 is released, but I won't be around during the week to > make sure it happens (unless someone ACKs in the next 5 hours or so :-) > > So - if/when you ACK the patch, please also push it. > > Thanks! ACK, too, I'm pushing this for rc2, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list