On 08/24/2012 12:58 AM, Daniel Veillard wrote: > On Thu, Aug 23, 2012 at 02:54:15PM -0600, Eric Blake wrote: >> This has several benefits: >> 1. Future snapshot-related code has a definite place to go (and I >> _will_ be adding some) >> 2. Snapshot errors now use the VIR_FROM_DOMAIN_SNAPSHOT error >> classification, which has been underutilized (previously only in >> libvirt.c) >> >> + * You should have received a copy of the GNU Lesser General Public >> + * License along with this library; If not, see >> + * <http://www.gnu.org/licenses/>. >> + * >> + * Author: Daniel P. Berrange <berrange@xxxxxxxxxx> > > Hum ... I would have guessed you're the author of most of that > snapshot related code, not Dan, so i would probably adjust this > accordingly I wasn't the original author of domainsnapshot objects (kudos to Chris Lalancette for first introducing them), but indeed I have rewritten most of the logic in this file to the point that the original design hardly remains. I'll make the change as suggested. > ACK, Thanks; pushed. -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list