On 08/21/2012 10:28 AM, Daniel P. Berrange wrote: > On Tue, Aug 21, 2012 at 11:01:44AM +0200, Ján Tomko wrote: >> Fix possible double close in the child process after the fork in case >> infd and outfd are equal, just like they are after being called from >> virNetSocketNewConnectCommand. >> --- >> src/util/command.c | 14 +++++--------- >> 1 files changed, 5 insertions(+), 9 deletions(-) > > ACK. Pushed. > > I'm wondering if there's some way we can test this in tests/commandtest.c > All I can think of is using a nasty LD_PRELOAD hack again to override > dup/open/close/etc and look for a double-close. Perhaps just leave it up > to valgrind Well, we _do_ log double-close via VIR_FORCE_CLOSE; maybe it's sufficient to set up a test case that opens a file for O_RDWR and passes that fd for stdin and stdout, then tracking if our logging flags anything? But I have not yet tried doing that in the testsuite. -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list