On 08/18/2012 03:38 PM, Kyle Mestery (kmestery) wrote: > On Aug 17, 2012, at 1:18 PM, Laine Stump wrote: >> BTW, I meant to point out that somehow you had gotten a gnulib submodule >> update added onto your patch. I removed that before I pushed it. > > Actually, I noticed this too. For some reason, when I build RPMs from the libvirt > git repo, this always happens. I assume this is not to be expected, but it's unclear > to me how it's happening. I notice it periodically too. I think maybe it happens when I do a rebase of a branch from master and someone has pushed a gnulib update in master since the previous rebase. It helps to run "git submodule update" (there's a way to make that automatic, I think, but I've forgotten how - Eric?). (The other thing that I always do is "git add" the files individually, rather than doing a blanket "add *". That way things like this (and .po files) don't sneak in by accident.) -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list