On 08/18/2012 12:38 AM, Eric Blake wrote: > Not complete, but this is what I got done in a couple hours after > complaining about Osier's series: > https://www.redhat.com/archives/libvir-list/2012-August/msg01247.html I hadn't noticed that virsh.c was split up like that either, but definitely I agree. Although I earlier begrudgingly went along with having the virsh-edit.c template #included by virsh.c (simply because it was better than what it was replacing), in general #including .c files is a very gross and misleading hack that should be avoided. -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list