On 08/16/2012 02:34 AM, Osier Yang wrote: >> >> - if (virMacAddrParse(macstr,&oldmac) != 0) { >> + if ((vlan = strchr(fileData, '\n'))) { >> + char *endptr; >> + >> + *vlan++ = 0; /* NULL terminate the mac address */ > > s/terminate/terminates/ Actually, 'terminate' is correct - this is a comment describing what the assignment is good for (convert arbitrary contents into 0 in order to NUL-terminate the vlan variable), not the vlan format itself (a valid vlan exists when NUL terminates the string). -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list