On 08/14/2012 12:59 PM, Thomas Woerner wrote:
> * configura.ac, spec file: firewalld now defaults to enabled, depends on
> dbus
> * fixed comment for with_firewalld define
> * bridge_driver, nwfilter_driver: new dbus filters to get FirewallD1.Reloaded
> signal and DBus.NameOwnerChanged on org.fedoraproject.FirewallD1
> * iptables, ebtables, nwfilter_ebiptables_driver: use firewall-cmd direct
> passthrough interface
> * spec file changed as requested
In spite of Dan's ACK,
> +++ b/src/util/ebtables.c
> @@ -176,11 +176,34 @@ ebtablesAddRemoveRule(ebtRules *rules, int action, const char *arg, ...)
> const char *s;
> int n, command_idx;
>
> +#if HAVE_FIREWALLD
> + int ret;
> + char *firewall_cmd_path = NULL;
> + virCommandPtr cmd = NULL;
> +
> + firewall_cmd_path = virFindFileInPath("firewall-cmd");
this is rather inefficient - doing a PATH lookup for every call to
ebtablesAddRemoveRule. Can we do the lookup just once and remember the
result?
--
Eric Blake eblake@xxxxxxxxxx +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list