Re: [PATCH 3/3] parallels: add domain configuration example

[Daniel Veillard <veillard@xxxxxxxxxx>]

On Mon, Aug 13, 2012 at 07:50:14PM +0400, Dmitry Guryanov wrote:
> 
> Signed-off-by: Dmitry Guryanov <dguryanov@xxxxxxxxxxxxx>
> ---
>  docs/drvparallels.html.in                          |   39 ++++++++++++++++++++
>  docs/schemas/domaincommon.rng                      |    1 +
>  .../domain-parallels-vm-simple.xml                 |   26 +++++++++++++
>  3 files changed, 66 insertions(+), 0 deletions(-)
>  create mode 100644 tests/domainschemadata/domain-parallels-vm-simple.xml
> 
> diff --git a/docs/drvparallels.html.in b/docs/drvparallels.html.in
> index 8e1430b..0a86451 100644
> --- a/docs/drvparallels.html.in
> +++ b/docs/drvparallels.html.in
> @@ -25,4 +25,43 @@ parallels://example.com/system          (remote access, TLS/x509)
>  parallels+tcp://example.com/system      (remote access, SASl/Kerberos)
>  parallels+ssh://root@xxxxxxxxxxx/system (remote access, SSH tunnelled)
>  </pre>
> +
> +    <h2><a name="example">Example guest domain XML configuration</a></h2>
> +
> +    <p>
> +    Parallels driver require at least one hard disk for new domains
> +    at this time. It is used for defining directory, where VM should
> +    be created.
> +    </p>
> +
> +<pre>
> +&lt;domain type='parallels'&gt;
> +  &lt;name&gt;demo&lt;/name&gt;
> +  &lt;uuid&gt;54cdecad-4492-4e31-a209-33cc21d64057&lt;/uuid&gt;
> +  &lt;description&gt;some description&lt;/description&gt;
> +  &lt;memory unit='KiB'&gt;1048576&lt;/memory&gt;
> +  &lt;currentMemory unit='KiB'&gt;1048576&lt;/currentMemory&gt;
> +  &lt;vcpu placement='static'&gt;2&lt;/vcpu&gt;
> +  &lt;os&gt;
> +    &lt;type arch='x86_64'&gt;hvm&lt;/type&gt;
> +  &lt;/os&gt;
> +  &lt;clock offset='utc'/&gt;
> +  &lt;on_poweroff&gt;destroy&lt;/on_poweroff&gt;
> +  &lt;on_reboot&gt;destroy&lt;/on_reboot&gt;
> +  &lt;on_crash&gt;destroy&lt;/on_crash&gt;
> +  &lt;devices&gt;
> +    &lt;disk type='file' device='disk'&gt;
> +      &lt;source file='/storage/vol1'/&gt;
> +      &lt;target dev='hda'/&gt;
> +    &lt;/disk&gt;
> +    &lt;video&gt;
> +      &lt;model type='vga' vram='33554432' heads='1'&gt;
> +        &lt;acceleration accel3d='no' accel2d='no'/&gt;
> +      &lt;/model&gt;
> +    &lt;/video&gt;
> +  &lt;/devices&gt;
> +&lt;/domain&gt;
> +
> +</pre>
> +
>  </body></html>
> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> index c85d763..1b94155 100644
> --- a/docs/schemas/domaincommon.rng
> +++ b/docs/schemas/domaincommon.rng
> @@ -179,6 +179,7 @@
>          <value>hyperv</value>
>          <value>vbox</value>
>          <value>phyp</value>
> +        <value>parallels</value>
>        </choice>
>      </attribute>
>    </define>
> diff --git a/tests/domainschemadata/domain-parallels-vm-simple.xml b/tests/domainschemadata/domain-parallels-vm-simple.xml
> new file mode 100644
> index 0000000..4e21583
> --- /dev/null
> +++ b/tests/domainschemadata/domain-parallels-vm-simple.xml
> @@ -0,0 +1,26 @@
> +<domain type='parallels'>
> +  <name>demo</name>
> +  <uuid>54cdecad-4492-4e31-a209-33cc21d64057</uuid>
> +  <description>some description</description>
> +  <memory unit='KiB'>1048576</memory>
> +  <currentMemory unit='KiB'>1048576</currentMemory>
> +  <vcpu placement='static'>2</vcpu>
> +  <os>
> +    <type arch='x86_64'>hvm</type>
> +  </os>
> +  <clock offset='utc'/>
> +  <on_poweroff>destroy</on_poweroff>
> +  <on_reboot>destroy</on_reboot>
> +  <on_crash>destroy</on_crash>
> +  <devices>
> +    <disk type='file' device='disk'>
> +      <source file='/storage/vol1'/>
> +      <target dev='hda'/>
> +    </disk>
> +    <video>
> +      <model type='vga' vram='33554432' heads='1'>
> +        <acceleration accel3d='no' accel2d='no'/>
> +      </model>
> +    </video>
> +  </devices>
> +</domain>

  Ahhh ! great :-)
I feel better to have the schemas updated and an example in
the doc and regression tests, ACK,

  I just pushed the 3 patches,

    thanks !

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel@xxxxxxxxxxxx  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list