On 08/07/2012 03:55 PM, Eric Blake wrote: > On 08/07/2012 11:21 AM, Guannan Ren wrote: >> Rename qemuDefaultScsiControllerModel to qemuCheckScsiControllerModel. >> When scsi model is given explicitly in XML(model > 0) checking if the >> underlying QEMU supports it or not first, raise an error on checking >> failure. >> When the model is not given(mode <= 0), return LSI by default, if >> the QEMU doesn't support it, raise an error. > > ACK. This patch introduces even more testsuite breaks than 1/3. Please fold the rest of 3/3 into this patch, and when you push, you should have just two patches, both with testsuite improvements, and where both patches in isolation pass 'make check'. And don't forget the /VIRIO/VIRTIO/ spelling fix. -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list