On 08/07/2012 07:38 AM, Daniel P. Berrange wrote: > On Mon, Aug 06, 2012 at 08:07:32PM -0400, Laine Stump wrote: >> This patch is in response to: >> >> https://bugzilla.redhat.com/show_bug.cgi?id=818467 >> >> If a caller to virCommandRun doesn't ask for the exitstatus of the >> program it's running, the virCommand functions assume that they should >> log an error message and return failure if the exit code isn't >> 0. However, only the commandline and exit status are logged, while >> potentially useful information sent by the program to stderr is >> discarded. >> >> Fortunately, virCommandRun is already checking if the caller had asked >> for stderr to be saved and, if not, sets things up to save it in >> *cmd->errbuf. This makes it fairly simple for virCommandWait to >> include *cmd->errbuf in the error log (there are still other callers >> that don't setup errbuf, and even virCommandRun won't set it up if the >> command is being daemonized, so we have to check that it's non-zero). > ACK > Pushed. Thanks! -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list