On Thu, Aug 02, 2012 at 11:46:07AM +0100, Daniel P. Berrange wrote: > On Thu, Aug 02, 2012 at 06:33:14PM +0800, Daniel Veillard wrote: > > On Thu, Aug 02, 2012 at 11:17:33AM +0100, Daniel P. Berrange wrote: > > > We need to fix libvirt_public.syms to refer to 0.10.0 instead of > > > 0.9.14. Likewise in some of the source files & docs we need to > > > remove 0.9.14 > > > > And replace it to the expected 0.10.0 > > > > diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in > > index c834577..f97c630 100644 > > --- a/docs/formatdomain.html.in > > +++ b/docs/formatdomain.html.in > > @@ -780,7 +780,7 @@ > > CPU model will fail. Supported values for <code>fallback</code> > > attribute are: <code>allow</code> (this is the default), and > > <code>forbid</code>. The optional <code>vendor_id</code> attribute > > - (<span class="since">Since 0.9.14</span>) can be used to set the > > + (<span class="since">Since 0.10.0</span>) can be used to set the > > vendor id seen by the guest. It must be exactly 12 characters long. > > If not set the vendor id of the host is used. Typical possible > > values are "AuthenticAMD" and "GenuineIntel".</dd> > > diff --git a/src/libvirt_public.syms b/src/libvirt_public.syms > > index 5004182..e3ba119 100644 > > --- a/src/libvirt_public.syms > > +++ b/src/libvirt_public.syms > > @@ -544,7 +544,7 @@ LIBVIRT_0.9.13 { > > virDomainSnapshotRef; > > } LIBVIRT_0.9.11; > > > > -LIBVIRT_0.9.14 { > > +LIBVIRT_0.10.0 { > > global: > > virDomainGetHostname; > > virConnectRegisterCloseCallback; > > diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c > > index 4cc7f46..48b5219 100644 > > --- a/src/openvz/openvz_driver.c > > +++ b/src/openvz/openvz_driver.c > > @@ -2170,7 +2170,7 @@ static virDriver openvzDriver = { > > .domainIsUpdated = openvzDomainIsUpdated, /* 0.8.6 */ > > .isAlive = openvzIsAlive, /* 0.9.8 */ > > .domainUpdateDeviceFlags = openvzDomainUpdateDeviceFlags, /* 0.9.13 */ > > - .domainGetHostname = openvzDomainGetHostname, /* 0.9.14 */ > > + .domainGetHostname = openvzDomainGetHostname, /* 0.10.0 */ > > }; > > > > int openvzRegister(void) { > > diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c > > index 9354cb4..b9e2127 100644 > > --- a/src/remote/remote_driver.c > > +++ b/src/remote/remote_driver.c > > @@ -5366,7 +5366,7 @@ static virDriver remote_driver = { > > .domainGetDiskErrors = remoteDomainGetDiskErrors, /* 0.9.10 */ > > .domainSetMetadata = remoteDomainSetMetadata, /* 0.9.10 */ > > .domainGetMetadata = remoteDomainGetMetadata, /* 0.9.10 */ > > - .domainGetHostname = remoteDomainGetHostname, /* 0.9.14 */ > > + .domainGetHostname = remoteDomainGetHostname, /* 0.10.0 */ > > }; > > > > static virNetworkDriver network_driver = { > > ACK identical to Eric's patch, but since his isn't pushed and he's > not online yet, go ahead with yours Actually I pushed his because he had more details in the commit :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list