On 07/31/2012 06:09 PM, Eric Blake wrote: > On 07/31/2012 10:58 AM, Daniel P. Berrange wrote: >> From: "Daniel P. Berrange" <berrange@xxxxxxxxxx> >> >> There are a few issues with the current virAtomic APIs >> >> - They require use of a virAtomicInt struct instead of a plain >> int type >> - Several of the methods do not implement memory barriers >> - The methods do not implement compiler re-ordering barriers >> - There is no Win32 native impl >> > > Reviewing the next part out of order, so as to hit implementation before > client's use of the implementation. > >> diff --git a/src/util/viratomic.c b/src/util/viratomic.c >> new file mode 100644 >> index 0000000..af846ff >> --- /dev/null >> +++ b/src/util/viratomic.c >> @@ -0,0 +1,35 @@ Oh, one more thing - run 'make syntax-check before pushing, and fix these: copyright_address src/util/viratomic.c:22: * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA tests/viratomictest.c:16: * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA maint.mk: Point to <http://www.gnu.org/licenses/>, not an address -- Eric Blake eblake@xxxxxxxxxx +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list