Peter Maydell <peter.maydell@xxxxxxxxxx> writes: > On 27 July 2012 14:37, Anthony Liguori <aliguori@xxxxxxxxxx> wrote: >> --- a/compiler.h >> +++ b/compiler.h >> @@ -45,6 +45,7 @@ >> # define GCC_ATTR __attribute__((__unused__, format(gnu_printf, 1, 2))) >> # define GCC_FMT_ATTR(n, m) __attribute__((format(gnu_printf, n, m))) >> # endif >> +#define GCC_WEAK __attribute__((weak)) >> #else >> #define GCC_ATTR /**/ >> #define GCC_FMT_ATTR(n, m) > > The GCC manual says "Weak symbols are supported for ELF targets, > and also for a.out targets when using the GNU assembler and linker". > Have you tested this on Windows and MacOSX ? > > (Also, no version of the macro in the not-GCC branch of the #if.) (We don't support any compiler other than GCC). Not really sure why it is even in a branch. Regards, Anthony Liguori > > -- PMM -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list