On 07/24/2012 06:09 PM, Doug Goldstein wrote:
> On Tue, Jul 24, 2012 at 9:06 AM, Martin Kletzander <mkletzan@xxxxxxxxxx> wrote:
>> The 'domdisplay' command didn't properly evaluate '--include-password'
>> option.
>> ---
>> v2:
>> - switched to using 'flags'
>> - kept the second condition in place
>> - fixed indentation after virAsprintf
>>
>> tools/virsh.c | 11 ++++++++---
>> 1 files changed, 8 insertions(+), 3 deletions(-)
>>
>> diff --git a/tools/virsh.c b/tools/virsh.c
>> index 5888d6c..5f96445 100644
>> --- a/tools/virsh.c
>> +++ b/tools/virsh.c
>> @@ -13870,6 +13870,7 @@ cmdDomDisplay(vshControl *ctl, const vshCmd *cmd)
>> const char *scheme[] = { "vnc", "spice", "rdp", NULL };
>> int iter = 0;
>> int tmp;
>> + int flags = 0;
>
> nit pick but virDomainGetXMLDesc() takes an unsigned int and not an int.
>
You're absolutely right, thanks for noticing. I see it's not the only
function in there, so I'll go through that and fix it everywhere. But
most probably I'll wait for Osier's patches to be in, first.
Martin
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list