On Fri, Jul 20, 2012 at 16:55:22 +0100, Daniel P. Berrange wrote: > On Fri, Jul 20, 2012 at 09:46:42AM -0600, Eric Blake wrote: > > > One remark up there, but no biggie. > > > > I had to hunt for that remark among 70k of verbatim patch. Not only is > > it okay to trim portions of the patch that you are happy with, but > > trimming actually helps focus on the problems. Just be sure you leave > > enough context to help the readers pinpoint where the problem was (as I > > did here, by including the @@ line at the start of the problematic hunk). > > I completely agree with your point, but if you have a good mutt > colour setup, it is fairly easy to scan through large mails and > distinguish new text vs quoted text at a glance. I even have > some magic settings to highlight patches in email Not that it helps our non-mutt colleagues :-) But thanks for the coloring idea. BTW, I just found mutt has something even better... you can use skip-quoted function (mapped to S by default) in mutt's pager to automagically skip to the next unquoted line in the email. Jirka -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list