On Fri, Jul 13, 2012 at 10:45:30AM +0200, Viktor Mihajlovski wrote: > From: J.B. Joret <jb@xxxxxxxxxxxxxxxxxx> > > Adding qemuxml2arg test for disk geometry in drive specification. > > Signed-off-by: J.B. Joret <jb@xxxxxxxxxxxxxxxxxx> > Signed-off-by: Viktor Mihajlovski <mihajlov@xxxxxxxxxxxxxxxxxx> > --- > .../qemuxml2argv-disk-geometry.args | 4 +++ > .../qemuxml2argv-disk-geometry.xml | 26 ++++++++++++++++++++ > tests/qemuxml2argvtest.c | 2 + > 3 files changed, 32 insertions(+), 0 deletions(-) > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-geometry.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-geometry.xml And this answers one of my other points about the first patch. It would be better if you move the qemu_command.c change out of the first patch, and into this patch. In others you wnat to end up with a total of 2 patches 1. The XML parsing, formatting, schema additions and docs 2. The QEMU command impl and the QEMU tests Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list