On 07/13/2012 03:05 AM, Guannan Ren wrote:
> From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
>
> When the guest changes its memory balloon applications may want
> to know what the new value is, without having to periodically
> poll on XML / domain info. Introduce a "balloon change" event
> to let apps see this
>
> * include/libvirt/libvirt.h.in: Define the
> virConnectDomainEventBalloonChangeCallback callback
> and VIR_DOMAIN_EVENT_ID_BALLOON_CHANGE constant
> * python/libvirt-override-virConnect.py,
> python/libvirt-override.c: Wire up helpers for new event
> * daemon/remote.c: Helper for serializing balloon event
> * examples/domain-events/events-c/event-test.c,
> examples/domain-events/events-python/event-test.py: Add
> example of balloon event usage
> * src/conf/domain_event.c, src/conf/domain_event.h: Handling
> of balloon events
> * src/remote/remote_driver.c: Add handler of balloon events
> * src/remote/remote_protocol.x: Define wire protocol for
> balloon events
> * src/remote_protocol-structs: Likewise.
> Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>
Typically, once one person has issued a Signed-off-by, and you make
further edits, then you should also add a signed-off-by, to show that
you contributed as well ('git commit --amend -s' can help). But libvirt
hasn't had any strict policy on s-o-b, so I don't really care too much.
The changes to examples and remote_protocol-structs look better, and the
rest of the patch had no comments from me in v1, so:
ACK.
--
Eric Blake eblake@xxxxxxxxxx +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list