On Mon, Jul 09, 2012 at 09:25:48AM +0200, Michal Privoznik wrote: > On 09.07.2012 05:21, Daniel Veillard wrote: > > On Sun, Jul 08, 2012 at 11:36:47AM -0700, Ata Bohra wrote: > >> From: Ata E Husain <ata.husain@xxxxxxxxxxx> > >> > >> Includes most of the dirver routines except DefineXML, I am working on it and will update patch for it soon. > > > > typo s/dirver/driver/ > > > > I guess you didn't really understand the reason why Doug asked you to > > go though git-send-email > > In general, I like git-send-email more than sending just pure patch. > With git-send-email we are not deprived of commit message, patch itself > is in the email body making writing of review notes easier. Otherwise > one has to transfer patch from attachment into the body anyway: > > e.g. https://www.redhat.com/archives/libvir-list/2012-July/msg00147.html > > For my disillusionment we have no how-to on this theme on our > libvirt.org site though. Then let's just add it to http://libvirt.org/hacking.html it's true that we suggest to do a "git diff", ahum, so it's really not Ata's fault :-) My guess is that the "usual" process slightly shifted as most people around became more familiar with git (me included !!!) It think I remember seeing a mail from Dan with how/why patch should be split into atomic operations, maybe we could also extend point 3/ with those. Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list