Re: [PATCH] qemu: Always set auth_supported for Ceph disks.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 25, 2012 at 05:44:01PM +0200, Wido den Hollander wrote:
> Recently the Ceph project defaulted auth_supported from 'none' to 'cephx'.
> 
> When no auth information was set for Ceph disks this would lead to librados defaulting to
> 'cephx', but there would be no additional authorization information.
> 
> We now explicitly set auth_supported to none when passing down arguments to Qemu.
> 
> Signed-off-by: Wido den Hollander <wido@xxxxxxxxx>
> ---
>  src/qemu/qemu_command.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index 6549f57..1c59695 100644
> --- a/src/qemu/qemu_command.c
> +++ b/src/qemu/qemu_command.c
> @@ -1782,6 +1782,8 @@ qemuBuildRBDString(virConnectPtr conn,
>                              disk->auth.username);
>              goto error;
>          }
> +    } else {
> +        virBufferAddLit(opt, ":auth_supported=none");
>      }
>  
>      if (disk->nhosts > 0) {

  That makes sense, yes, ACK, i'm pushing this !

    thanks,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel@xxxxxxxxxxxx  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]