On 07/02/2012 12:55 PM, Josh Durgin wrote:
> QEMU (and librbd) flush the cache on the source before the
> destination starts, and the destination does not read any
> changeable data before that, so live migration with rbd caching
> is safe.
>
> This makes 'virsh migrate' work with rbd and caching without the
> --unsafe flag.
>
> Reported-by: Vladimir Bashkirtsev <vladimir@xxxxxxxxxxxxxxx>
> Signed-off-by: Josh Durgin <josh.durgin@xxxxxxxxxxx>
> ---
> src/qemu/qemu_migration.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
> index 48369d6..f51c99a 100644
> --- a/src/qemu/qemu_migration.c
> +++ b/src/qemu/qemu_migration.c
> @@ -847,6 +847,9 @@ qemuMigrationIsSafe(virDomainDefPtr def)
> continue;
> else if (cfs < 0)
> return false;
> + } else if (disk->type == VIR_DOMAIN_DISK_TYPE_NETWORK &&
> + disk->protocol == VIR_DOMAIN_DISK_PROTOCOL_RBD) {
> + continue;
> }
ACK. However, before I push, I note that you are previously listed in
AUTHORS under a different email address. Which of the two addresses do
you prefer, so that we can update .mailmap and keep 'make syntax-check'
happy?
--
Eric Blake eblake@xxxxxxxxxx +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list